101056 - Edit attachment and login page don't work well together [dataloss]

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Johnny Stenback (:jst)]

If you haven't logged in to bugzilla and you go and edit an attachment and click
submit, bugzilla takes you to the login page and once you've logged in bugzilla
says that "One or more of the statuses changed are invalid", or something like
that. If you click back in the browser and go to the edit attachement page again
and click submit again everything work fine...

Annoying.

Comment 1

[Daniel Veditz [:dveditz]]

It's worse than that, several times I have *LOST* long review comments doing
this. After getting this error and backing up the checkbox state is preserved,
but the "Edit As Comment" edits are gone, gone, gone.

Just tonight I've made the same mistake twice before I figured this out.
Happened before I left for home, only I didn't notice the comments were gone and
the assignee wanted to know why I marked "needs work" and didn't say why. Then
at home I typed in all the comments again and the same darn thing happened, only
this time I noticed they were gone. It has not been a good night.

Comment 2

[Matthew Tuck [:CodeMachine]]

And bug #103322.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 53305 [details] [diff] [review]
patch v1: fixes problem

Seems OK to me... r=gerv.

Gerv

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 53305 [details] [diff] [review]
patch v1: fixes problem

r= justdave

Comment 6

[Dave Miller [:justdave]]

/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.112; previous revision: 1.111

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: uses different syntax

Comment 8

[Daniel Veditz [:dveditz]]

*** Bug 103322 has been marked as a duplicate of this bug. ***

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Because of the severity of the problem, I have applied the patch to b.m.o. 
Effective immediately, this problem is solved on that Bugzilla installation.

Comment 10

[Dave Miller [:justdave]]

Fixed for 2.16

Comment 11

[Dave Miller [:justdave]]

no, really this time :)