1010612 - js/src/jsdate.cpp:3156:25: warning: unused variable 'sReadOnlyDateMethods' [-Wunused-const-variable]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning, in clang --disable-unified-compilation builds:
{
js/src/jsdate.cpp:3156:25: warning: unused variable 'sReadOnlyDateMethods' [-Wunused-const-variable]
}

Last usage of this variable was removed in bug 975042, here:
http://hg.mozilla.org/mozilla-central/rev/c6d6fcd028fd#l1.21

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Requesting review from bholley, since he removed the last usage.

For good measure, here's a MXR search showing no usages:
 http://mxr.mozilla.org/mozilla-central/search?string=sReadOnlyDateMethods

Comment 2

[Daniel Holbert [:dholbert]]

oops, that patch includes some unrelated tweaks. New version coming in a sec...

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v2

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4741b1c7ae

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4d4741b1c7ae