Closed Bug 1010621 Opened 5 years ago Closed 5 years ago

js/src/jit/IonMacroAssembler.cpp:1208:1: warning: unused function 'IsCompilingAsmJS' [-Wunused-function]

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STR:
 1. Build with clang (I'm using version 3.5) and with these mozconfig options:
 ac_add_options --enable-debug --disable-optimize
 ac_add_options --disable-unified-compilation

ACTUAL RESULTS:
 Build warning:
{
js/src/jit/IonMacroAssembler.cpp:1208:1: warning: unused function 'IsCompilingAsmJS' [-Wunused-function]
}

This function *looks* like it's used (the function right below has a call to it), but that call actually ends up using a different inline function with the same name, which is defined in a header file here:
http://mxr.mozilla.org/mozilla-central/source/js/src/jit/shared/Assembler-shared.h?rev=f742f98f4d04#107

Fortunately, these two versions of the function are identical, so we haven't been secretly doing the wrong thing, or anything like that.

We should just remove the extra one in the .cpp file.
Looks like bug 947188 added the bonus version of the function in the .cpp file. (The version in the .h file predated that bug by a few months.)
Blocks: 947188
Attached patch fix v1Splinter Review
Attachment #8422848 - Flags: review?(kvijayan)
Try run, to be sure we don't actually need this local function-definition on some platform:
 https://tbpl.mozilla.org/?tree=Try&rev=c89fbf47162c
Attachment #8422848 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/mozilla-central/rev/dff6a8c71b3f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.