1010643 - (vertical-homescreen) Divider line at the bottom of the screen in edit mode doesn't leave a gap

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P3)

Description

[Peter La]

In icon edit mode, there should be a gap between the divider line at the bottom of the screen and the bottom edge of the screen.  Currently, the line is touching the bottom.  Please see refer to row 2 of  this spec for details:

https://mozilla.box.com/s/gl2fjrkzlnyylmnlnw13

Comment 1

[Kevin Grandon :kgrandon]

Hey Peter - it says that box item is currently unavailable to me. Could you by chance upload the relevant spec page to these bugs or put expected rems/pixels in them for easy access? Thanks!

Comment 2

[Kevin Grandon :kgrandon]

Hmm, I found this so maybe it's still the same? https://mozilla.box.com/s/65hcq8nmnm3xpixpazxf

Comment 3

[Kevin Grandon :kgrandon]

I'll try to implement the 1.2 rem spacing as specified in the spec. (We're still waiting on implementation of divider styling).

Comment 4

[Kevin Grandon :kgrandon]

Changed implementation to provide a 1.2rem padding for the last divider. (This also means that there is a slight space at the end of the last icon row before entering edit mode, but there's not much we can do about that).

Peter - please take a look and let me know if we need additional tweaks. Might be better to hold off until we finish the visual styling of the dividers though.

https://github.com/mozilla-b2g/gaia/commit/704d56b879fabcbc44aafb1a15feb45e098f2227

Comment 5

[Peter La]

Attachment: Screenshots.zip

Hi Kevin,

I just loaded master and the gap you implemented is pretty close to spec, it's just a little bit taller, but it's not bad.  I've attached screenshots.

For Inari, I measured a 15 px gap from bottom to center of divider > it's spec'd at 12 px.
For Flame, I measured a 21 px gap from bottom to center of divder > it should be 12 px x 1.5 scale factor = 18 px.

Having said that it visually looks not too bad, and I would accept this minor difference.

Comment 6

[Kevin Grandon :kgrandon]

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.