Closed Bug 1010643 Opened 6 years ago Closed 6 years ago

(vertical-homescreen) Divider line at the bottom of the screen in edit mode doesn't leave a gap

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P3)

x86
macOS
defect

Tracking

(feature-b2g:2.0, b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S2 (23may)
feature-b2g 2.0
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: pla, Assigned: kgrandon)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, [ft:systemsfe],[p=1])

Attachments

(1 file)

693.84 KB, application/zip
Details
In icon edit mode, there should be a gap between the divider line at the bottom of the screen and the bottom edge of the screen.  Currently, the line is touching the bottom.  Please see refer to row 2 of  this spec for details:

https://mozilla.box.com/s/gl2fjrkzlnyylmnlnw13
Hey Peter - it says that box item is currently unavailable to me. Could you by chance upload the relevant spec page to these bugs or put expected rems/pixels in them for easy access? Thanks!
Flags: needinfo?(pla)
Hmm, I found this so maybe it's still the same? https://mozilla.box.com/s/65hcq8nmnm3xpixpazxf
I'll try to implement the 1.2 rem spacing as specified in the spec. (We're still waiting on implementation of divider styling).
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Flags: needinfo?(pla)
Whiteboard: ux-tracking, visual design, visual-tracking, [ft:systemsfe] → ux-tracking, visual design, visual-tracking, [ft:systemsfe],[p=1]
Target Milestone: --- → 2.0 S2 (23may)
Changed implementation to provide a 1.2rem padding for the last divider. (This also means that there is a slight space at the end of the last icon row before entering edit mode, but there's not much we can do about that).

Peter - please take a look and let me know if we need additional tweaks. Might be better to hold off until we finish the visual styling of the dividers though.

https://github.com/mozilla-b2g/gaia/commit/704d56b879fabcbc44aafb1a15feb45e098f2227
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
feature-b2g: --- → 2.0
Priority: -- → P3
Attached file Screenshots.zip
Hi Kevin,

I just loaded master and the gap you implemented is pretty close to spec, it's just a little bit taller, but it's not bad.  I've attached screenshots.

For Inari, I measured a 15 px gap from bottom to center of divider > it's spec'd at 12 px.
For Flame, I measured a 21 px gap from bottom to center of divder > it should be 12 px x 1.5 scale factor = 18 px.

Having said that it visually looks not too bad, and I would accept this minor difference.
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
blocking-b2g: --- → 2.0?
blocking-b2g: 2.0? → ---
You need to log in before you can comment on or make changes to this bug.