1010729 - Add a virtual pageview tracking function to webmaker-analytics

Status: RESOLVED FIXED

(Webmaker Graveyard :: Metrics, defect, P3)

Description

[Adam Lofting (:adamlofting)]

In some cases within our sites it would be useful to track virtual page views in Google Analytics. These are different from event tracking as they allow us to understand user-flow between pages. Event tracking is not sequential.

The first place we want to use this is to record a virtual page view for the create new user modal. Technically this modal can appear over any page on webmaker, but from a UX tracking point of view it is a sequential step for the user to engage with.

To track these pageviews we should update the webmaker-analytics module, using the same design as the event tracking function:

https://github.com/mozilla/webmaker-analytics

* Add analytics.virtualpageview("pagename") event
* Prefix all of these with "/virtual/" so they get recorded in GA as "/virtual/pagename"
* Update tests
* Update documentation

Comment 1

[Adam Lofting (:adamlofting)]

Attachment: https://github.com/mozilla/webmaker-analytics/pull/3

Comment 2

[David Humphrey (:humph)]

Comment on attachment 8429274 [details] [review]
https://github.com/mozilla/webmaker-analytics/pull/3

A few suggestions for code simplification.  r=me with those.  I haven't run the tests, Scott can do that maybe?

Comment 3

[Adam Lofting (:adamlofting)]

(In reply to David Humphrey (:humph) from comment #2)
> Comment on attachment 8429274 [details] [review]
> https://github.com/mozilla/webmaker-analytics/pull/3
> 
> A few suggestions for code simplification.  
Much appreciated :) 

> r=me with those.  
I'm not sure what that means? (is 'me' 'maybe'?)

Comment 4

[Jon Buckley [:jbuck]]

Comment on attachment 8429274 [details] [review]
https://github.com/mozilla/webmaker-analytics/pull/3

Going to steal this review while Scott's away on the Appmaker workweek

Comment 5

[Adam Lofting (:adamlofting)]

@jbuck, if it's possible to review this at the same time as Bug 1027041, we can merge and make both upgrades at the same time. 

But if you're stretched, this one is not urgent.

Comment 6

[Jon Buckley [:jbuck]]

Comment on attachment 8429274 [details] [review]
https://github.com/mozilla/webmaker-analytics/pull/3

r+ with one nit, don't bump the version number