Toolbar refinement - Update curve shape to play better with Australis

VERIFIED FIXED in Firefox 34

Status

()

defect
VERIFIED FIXED
5 years ago
3 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 34
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox34 verified)

Details

Attachments

(4 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Blocks: 917891
Current tab curve on Android is shown in red, compared to the new adapted shape shown in blue.
Brought the curve a bit closer to divide the space before the subsequent icon better and to hug the input field better
(Assignee)

Updated

5 years ago
Attachment #8423916 - Flags: review?(margaret.leibovic)
(Assignee)

Updated

5 years ago
Depends on: 1011533
Comment on attachment 8423916 [details] [diff] [review]
Change curve shape to be more consistent with Australis (r=margaret)

Review of attachment 8423916 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't build this to test, but I'll trust your math :)
Attachment #8423916 - Flags: review?(margaret.leibovic) → review+
Blocks: 1014848
(Assignee)

Updated

5 years ago
Attachment #8423916 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
Comment on attachment 8471535 [details] [diff] [review]
Change curve shape to be more consistent with Australis (r=margaret)

Updated with the new tab shape we're planning to use on both tablet and phone UIs.
Attachment #8471535 - Flags: review?(margaret.leibovic)

Updated

5 years ago
Attachment #8471535 - Flags: review?(margaret.leibovic) → review+
Posted image Comparison
I'm being an old man, but are we sure this is right? Overlapping this with Desktop's the two don't match. There's definitely more vertical stretch in the middle here than on desktop (i.e. if you zoom you can see a straight strip in the middle of this that isn't present in Desktop tabs).
(In reply to Wesley Johnston (:wesj) from comment #7)
> Created attachment 8473767 [details]
> Comparison
> 
> I'm being an old man, but are we sure this is right? Overlapping this with
> Desktop's the two don't match. There's definitely more vertical stretch in
> the middle here than on desktop (i.e. if you zoom you can see a straight
> strip in the middle of this that isn't present in Desktop tabs).

Good eye wesj! :D Maybe the title of this bug was a bit misleading but it should've been more about refining our current curve. It started off as an effort to map out a curve identical to Australis but in practice on a phone the curve was still awkward so this was about finding that happy medium.

Something we also looked at was how the curve hugged around the input box, how the inner shadow and highlight provided the visual affordance and worked with the aforementioned curve. Since we were trying out less corner radius and actually making it closer to modern conventions of the input box (like on Australis), the straighter edge actually helped.

All this was also in consideration of how it might look on tablets with our efforts to bring "tabs on top" to that side of the experience as well. These curves lent themselves better to both saving space and dividing content. :)

I should probably rename this bug... :P
Summary: Toolbar refinement - Change curve shape to be consistent with Australis → Toolbar refinement - Update curve shape to play better with Australis
Backed out along with the rest of the patch stack for robocop failures.
https://hg.mozilla.org/integration/fx-team/rev/d18d3e14ac3e
(Assignee)

Comment 11

5 years ago
The string changes in bug 1010741 caused the failures. Forgot to update the tests accordingly. Try build looks nice and green now, pushed:

https://hg.mozilla.org/integration/fx-team/rev/03b97b1ea39b
https://hg.mozilla.org/mozilla-central/rev/03b97b1ea39b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
The curve hype is real
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.