Closed Bug 1010741 Opened 6 years ago Closed 5 years ago

Toolbar refinement - Change text style in toolbar and search hint in about:home

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 34

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(4 files, 1 obsolete file)

No description provided.
Attached image URLbar_mock1.png
Font: Roboto light, vertically centered, size 42 (at XXHDPI), 14 sp 
Alignment: padded 20px (at XXHDPI) from the icon to the left, 7 dp 
Font fallback: Roboto regular
Color: #777777
Attached file icon_search.zip
Search icons attached at MDPI, HDPI, XHDPI, XXHDPI
Attachment #8471541 - Flags: review?(margaret.leibovic)
Attachment #8471537 - Flags: review?(michael.l.comella)
Attachment #8471541 - Flags: review?(margaret.leibovic) → review+
Attachment #8471537 - Flags: review?(michael.l.comella) → review+
FYI: I'm going to implement the search icon change in a follow-up (bug 1054268).
Comment on attachment 8473688 [details] [diff] [review]
Show search icon in about:home (r=margaret)

Wrong bug.
Attachment #8473688 - Attachment is obsolete: true
Summary: Toolbar refinement - Show search icon and change text hint in about:home → Toolbar refinement - Change text style in toolbar and search hint in about:home
Kudos to you for having the guts to land a giant stack of patches like this on a Friday night, but unfortunately I had to back it all out for robocop failures.
https://hg.mozilla.org/integration/fx-team/rev/d18d3e14ac3e

https://tbpl.mozilla.org/php/getParsedLog.php?id=46051162&tree=Fx-Team
Also appears to have made robocop-1 basically perma-fail as well.
The string changes in this bug caused the failures. Forgot to update the tests accordingly. Try build looks nice and green now, pushed:

https://hg.mozilla.org/integration/fx-team/rev/a22c03c7a4c0
https://hg.mozilla.org/integration/fx-team/rev/45ed18e439d1
https://hg.mozilla.org/mozilla-central/rev/a22c03c7a4c0
https://hg.mozilla.org/mozilla-central/rev/45ed18e439d1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.