1010749 - [FTU-Separation] Extract import build logic into a common file in order to be used as well by FTU app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

We are going to separate parts of the comms build process related to import logic in a common js file in order to enable its reuse by the FTU app

Comment 1

[Jose Manuel Cantera]

Attachment: 19274.html

Comment 2

[Albert [:albert]]

Comment on attachment 8423045 [details]
19274.html

Looks good!

I left some comments in github.

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8423045 [details]
19274.html

pre discussion on IRC with Jose, this build script will generate a configuration file which will be used in communications and ftu app, so it should be a gaia-wide build script and generate file into shared/ directory just like keyboard-layouts.js, so please set me review flag again if pull request is updated.

BTW, our goal for build system it NOT put anything into source tree such as apps/* and shared/*, so we will have a follow up bug to sovle this issue to avoid generating config files to shared/ directory.

Comment 4

[Jose Manuel Cantera]

Comment on attachment 8423045 [details]
19274.html

Hi Yuren,

I think your comments have been addressed. Please check

thanks!

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8423045 [details]
19274.html

Jose, per discussion on IRC, please execute it as a gaia-wide build script.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8423045 [details]
19274.html

looks good to me, r=yurenju

per discussion on irc with Jose, import-config.js will be used in FTU app in future, so it's fine to put it in GAIA_DIR/build/.

please address nits which are mentioned on github before land it, thanks Jose!

Comment 7

[Jose Manuel Cantera]

landed in master:

https://github.com/mozilla-b2g/gaia/commit/831a0fb7f9aee4a1198bdbc7dfaa8153c06e47a8

(thanks albert and Yuren for the advice and review)