Closed Bug 1011045 Opened 6 years ago Closed 6 years ago

Simplify AnyRegister and pass it by value too

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: sunfish, Assigned: sunfish)

Details

Attachments

(2 files)

Inspired by bug 1010775, here's a patch which simplifies AnyRegister so that it's just a single field, and a patch which changes all the code which passes AnyRegisters around to pass them by value instead of const reference.
Attachment #8423193 - Flags: review?(jdemooij)
Attachment #8423194 - Flags: review?(jdemooij)
Comment on attachment 8423193 [details] [diff] [review]
shrink-anyregisters.patch

Review of attachment 8423193 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/RegisterSets.h
@@ +53,3 @@
>      }
>      bool operator ==(const AnyRegister &other) const {
> +        return code_ == other.code_;

Ah, much simpler.
Attachment #8423193 - Flags: review?(jdemooij) → review+
Attachment #8423194 - Flags: review?(jdemooij) → review+
You need to log in before you can comment on or make changes to this bug.