1011123 - [FTU] Remove unneeded script types

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Kevin Grandon :kgrandon]

There are a lot of type="text/javascript" in the FTU index file. We've been removing them from other applications, so I think we should remove them from here as well.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey - quick review anyone? Thanks!

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8423287 [details] [review]
Github pull request

I'm fine with all the text/javascript stuff removed. R+ if you keep the text/css bits though.

Comment 3

[Kevin Grandon :kgrandon]

(In reply to Vivien Nicolas (:vingtetun) (:21) (NOT reading bugmails, needinfo? please) from comment #2)
> Comment on attachment 8423287 [details] [review]
> Github pull request
> 
> I'm fine with all the text/javascript stuff removed. R+ if you keep the
> text/css bits though.

Thanks. About the text/css, Everything seems to function fine without them. Also http://www.w3.org/html/wg/drafts/html/master/document-metadata.html#attr-link-type says that it's purely advisory.

Additionally the default value is "text/css" for stylesheets: http://www.w3.org/TR/html5/links.html#link-type-stylesheet

Comment 4

[Kevin Grandon :kgrandon]

Vivien - are you ok with landing this with text/css removed as per comment 3?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Kevin Grandon :kgrandon from comment #3)
> (In reply to Vivien Nicolas (:vingtetun) (:21) (NOT reading bugmails,
> needinfo? please) from comment #2)
> > Comment on attachment 8423287 [details] [review]
> > Github pull request
> > 
> > I'm fine with all the text/javascript stuff removed. R+ if you keep the
> > text/css bits though.
> 
> Thanks. About the text/css, Everything seems to function fine without them.
> Also
> http://www.w3.org/html/wg/drafts/html/master/document-metadata.html#attr-
> link-type says that it's purely advisory.
> 
> Additionally the default value is "text/css" for stylesheets:
> http://www.w3.org/TR/html5/links.html#link-type-stylesheet

I really don't have a strong opinion on this. Let's needinfo dbaron, and he says this is useless in our use case, let's remove it.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Yeah, given what the spec (also at http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#link-type-stylesheet ) says about the default type for link rel="stylesheet" and the fact that that's been the reality for over a decade, I think it's fine to remove the type="text/css".

Comment 7

[Kevin Grandon :kgrandon]

Thanks.. I'm a fan of less attributes where possible, and some apps already do this - so let's remove for now. If people get annoyed by it, or it causes any weird performance/testing issues - I'll gladly bring them back.

https://github.com/mozilla-b2g/gaia/commit/691b32151d384b955e0428911ccf1062c89f76ae