Closed Bug 1011147 Opened 10 years ago Closed 10 years ago

Move patch file path to a config variable in the selenium_test.conf file

Categories

(Bugzilla :: QA Test Scripts, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dkl, Assigned: dkl)

Details

Attachments

(1 file)

The patch file used by certain selenium test scripts should be stored in a location set by a config variable in selenium_test.conf instead of hard coded in the tests scripts
Attached patch 1011147_1.patchSplinter Review
Also kicked off a test run with this patch applied at:
https://travis-ci.org/dklawren/bugzilla/builds/25274640
Attachment #8423369 - Flags: review?(LpSolit)
as far as i can tell, the changes config/patch.diff are no longer required.
trunk, 4.4, and 4.0 already contain its changes.

would it be simpler to simply remove that patch?
(In reply to Byron Jones ‹:glob› from comment #2)
> as far as i can tell, the changes config/patch.diff are no longer required.
> trunk, 4.4, and 4.0 already contain its changes.
> 
> would it be simpler to simply remove that patch?

Its not actually applying the patch just using it as a sample attachment file. Could be any arbitrary patch.

dkl
Attachment #8423369 - Flags: review?(LpSolit)
To ssh://gitolite3@git.mozilla.org/bugzilla/qa.git
   c63000e..568bc89  4.4 -> 4.4

To ssh://gitolite3@git.mozilla.org/bugzilla/qa.git
   b464beb..d467c24  4.2 -> 4.2

To ssh://gitolite3@git.mozilla.org/bugzilla/qa.git
   a73818d..fcd82d0  4.0 -> 4.0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: