Closed
Bug 1011172
Opened 10 years ago
Closed 10 years ago
Remove obsolete images from tabbrowser/
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 32
People
(Reporter: dao, Assigned: jmaccor1012)
Details
(Whiteboard: [good first bug][mentor=dao])
Attachments
(1 file)
|
9.07 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
These images aren't used anymore: http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/tabbrowser/tab.png http://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/tabbrowser/tab.png We should remove them along with their jar.mn entries: http://mxr.mozilla.org/mozilla-central/search?string=%2Ftab.png
Flags: firefox-backlog+
|
Reporter | |
Comment 1•10 years ago
|
||
And some more: http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/tabbrowser/tabbar-bottom-bg-active.png http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/tabbrowser/tabbar-bottom-bg-inactive.png http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/tabbrowser/tabbar-top-bg-active.png http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/tabbrowser/tabbar-top-bg-inactive.png ... all listed in http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/jar.mn
Summary: Remove obsolete tab.png files → Remove obsolete images from tabbrowser/
|
||
Comment 2•10 years ago
|
||
Dao, are you mentoring this? sounds like a good first bug.
|
|
||
Comment 3•10 years ago
|
||
ops, nevermind, I somehow missed the whiteboard :/
I'd like to take a stab at this, seems pretty straightforward. Patch is attached. Only thing I'm not sure about is the proper person to review this. Not sure if I set it to the right person or not.
Attachment #8425713 -
Flags: review?(dao)
|
|
Reporter | |
Comment 5•10 years ago
|
||
Comment on attachment 8425713 [details] [diff] [review] patch1.patch thanks!
Attachment #8425713 -
Flags: review?(dao) → review+
|
|
Reporter | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Updated•10 years ago
|
Assignee: nobody → jmaccor93
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b6a70edc444a
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=dao] → [good first bug][mentor=dao][fixed-in-fx-team]
|
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b6a70edc444a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=dao][fixed-in-fx-team] → [good first bug][mentor=dao]
Target Milestone: --- → Firefox 32
You need to log in
before you can comment on or make changes to this bug.
Description
•