Closed Bug 1011287 Opened 6 years ago Closed 6 years ago

Check if debugger server loading needs to be done differently for Thunderbird after bug 859372

Categories

(Thunderbird :: General, defect)

30 Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 32.0

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

They changed the loader in bug 859372, fennec needed to make some changes. We might also want to add a similar test as in bug 1010750.
Attached patch Fix - v1 — — Splinter Review
Here is the patch. I went without a test for now as just starting the server isn't as helpful as we might think. This bug would have not been caught this way.

For this to work, the devtools webbrowser actor must export BrowserTabActor which I've requested. If they don't do it in that bug, I need to create a new one to make it happen.
Attachment #8424169 - Flags: review?(mconley)
Comment on attachment 8424169 [details] [diff] [review]
Fix - v1

Review of attachment 8424169 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8424169 - Flags: review?(mconley) → review+
https://hg.mozilla.org/comm-central/rev/8b21e2011df4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0
You need to log in before you can comment on or make changes to this bug.