Closed
Bug 1011287
Opened 12 years ago
Closed 12 years ago
Check if debugger server loading needs to be done differently for Thunderbird after bug 859372
Categories
(Thunderbird :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 32.0
People
(Reporter: Fallen, Assigned: Fallen)
References
Details
Attachments
(1 file)
|
4.06 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
They changed the loader in bug 859372, fennec needed to make some changes. We might also want to add a similar test as in bug 1010750.
|
Assignee | |
Comment 1•12 years ago
|
||
Here is the patch. I went without a test for now as just starting the server isn't as helpful as we might think. This bug would have not been caught this way.
For this to work, the devtools webbrowser actor must export BrowserTabActor which I've requested. If they don't do it in that bug, I need to create a new one to make it happen.
Attachment #8424169 -
Flags: review?(mconley)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8424169 [details] [diff] [review]
Fix - v1
Review of attachment 8424169 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
Attachment #8424169 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0
You need to log in
before you can comment on or make changes to this bug.
Description
•