1011342 - [B2G][Camera] Focus and metering areas APIs provide wrong coordinates to driver

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

The camera drivers expect the focus and metering regions to be provided in the form:

(x1,y1,x2,y2,weight)

Where x refers to left/right and y refers to top/bottom. Presently the gonk layer provides it in the form (y1,x1,y2,x2,weight).

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1011342.patch, v1

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8423526 [details] [diff] [review]
bug1011342.patch, v1

Review of attachment 8423526 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me

Comment 3

[Diego Marcos [:dmarcos]]

What is the ETA for this?

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

As soon as the try finishes and a sheriff checks the patch in for me.

try: https://tbpl.mozilla.org/?tree=Try&rev=e36e1f619988

Comment 5

[Carsten Book [:Tomcat]]

hey Andrew have you looked at the try results (see https://tbpl.mozilla.org/php/getParsedLog.php?id=40005889&tree=Try as example). Could this be related to your push?

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

Andrew, it looks like you need to fix this[1] as well.

1. http://dxr.mozilla.org/mozilla-central/source/dom/camera/GonkCameraParameters.cpp#428

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Mike Habicher [:mikeh] from comment #6)
> Andrew, it looks like you need to fix this[1] as well.
> 
> 1.
> http://dxr.mozilla.org/mozilla-central/source/dom/camera/
> GonkCameraParameters.cpp#428

That also explains the test case failure. New try with that fix: https://tbpl.mozilla.org/?tree=Try&rev=ed2e3596df74

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1011342.patch, v2 [r=dhylands]

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8425576 [details] [diff] [review]
bug1011342.patch, v2 [r=dhylands]

Review of attachment 8425576 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/251505cf32f5

Comment 11

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/251505cf32f5