1011355 - Minor FreeSpan/FreeList clean-ups

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

I have three clean-up patches.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove FreeList::allocateFromNewArena()

This patch removes allocateFromNewArena.  All FreeList allocations now occur in
allocate(), which is nice.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Add a CompactFreeSpan class

ArenaHeader uses a compact FreeSpan representation to save space. The
implementation of this is, uh, lower-level than is ideal. This patch introduces
a new class CompactFreeSpan to remedy this. The resulting code is a little more
verbose but much more readable, and it avoids manual shifting and masking.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Tiny FreeSpan tweaks

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8423566 [details] [diff] [review]
Remove FreeList::allocateFromNewArena()

Review of attachment 8423566 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +1599,2 @@
>      JS_ASSERT(!aheader->hasFreeThings());
> +    Arena* arena = aheader->getArena();

Oops, just noticed that the * should go with |arena|.

Comment 5

[Nicholas Nethercote [inactive]]

Thanks for the fast reviews!

https://hg.mozilla.org/integration/mozilla-inbound/rev/734a94168769
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a3df055066a
https://hg.mozilla.org/integration/mozilla-inbound/rev/5385817bdae6

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/734a94168769
https://hg.mozilla.org/mozilla-central/rev/6a3df055066a
https://hg.mozilla.org/mozilla-central/rev/5385817bdae6