1011365 - [B2G][Browser]Showing the rightmost character when URL is selected

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[howie [:howie]]

Attachment: [keyboard] v2.0 text selection and copy paste v0.3.pdf

For FF OS v2.0 text selection feature, when selecting the url, it should show the rightmost character. Please refer to the spec p.10, step 2.

Comment 1

[howie [:howie]]

Hi Candice, sorry for the late notice, there's one browser related thing might need your help. Could you see if you can find someone to solve it? Thank you.

Comment 2

[Dale Harvey (:daleharvey)]

Hey howie, what additional support do you need from the browser? its a plain text field and I cant see from the spec any unique functionality, but happy to help out if I can

Comment 3

[howie [:howie]]

Hi Dale, thank you! Do you see page 10 of the spec, when user taps on the url bar, the url selected all and scrolled to the right end? Currently, when tapping the url, it's selected all but no scrolling to the end of it; take the spec for example, in url bar now you see http://activeapplication.. instead of ...tiveapplication.net/  after tapping on it.

Comment 4

[howie [:howie]]

Hi Dale, are you going to work on this? :)

Comment 5

[Dale Harvey (:daleharvey)]

I see what you mean now, and yeh thats exclusive to the browser app, will do, cheers

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/19639

I filed https://t.co/su45C06SAu for why we needed to switch to setSelectionRange to do this.

Attempted to do the same with the rocketbar, but there are a few bugs in its focus functionality so will address seperately

Comment 7

[Ben Francis [:benfrancis]]

Comment on attachment 8428637 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19639

This is pretty cool.

One comment on GitHub.

Comment 8

[Ben Francis [:benfrancis]]

Comment on attachment 8428637 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19639

r+ with nits fixed

Comment 9

[Dale Harvey (:daleharvey)]

Addressed review comment and landed in: https://github.com/mozilla-b2g/gaia/commit/ea2e278ad0d93c06fb4cdb86509688c98f7b0ae5

Comment 10

[howie [:howie]]

cool! Thanks Dale!