Closed Bug 1011410 Opened 8 years ago Closed 8 years ago

[Settings] Expose geolocation debugging setting

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S2 (23may)

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Link to Github https://github.com/mozilla-b2g/gaia/pull/19315
46 bytes, text/x-github-pull-request
arthurcc
: review+
Details | Review 
Geolocation code now allows to enable some debug output in logcat via the geolocation.debugging.enabled setting.

Exposing this in the developper panel would be useful: it allows an easy access to the NMEA dumps, for example. Those can be very handy when debugging GPS issues.
Assignee: nobody → lissyx+mozillians
Arthur, please find attached a pull request fixing the issue.
Attachment #8423732 - Flags: review?(arthur.chen)
Comment on attachment 8423732 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/19315

Thanks for the patch. I would suggest to place the item before the "Wi-Fi output" item to make related items be displayed together.
Attachment #8423732 - Flags: review?(arthur.chen)
Comment on attachment 8423732 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/19315

Moved before Wi-Fi :)
Attachment #8423732 - Flags: review?(arthur.chen)
Comment on attachment 8423732 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/19315

r=me, thanks!
Attachment #8423732 - Flags: review?(arthur.chen) → review+
https://github.com/mozilla-b2g/gaia/commit/ba74c2a90184ff3742d292872abd1073c53a42d0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S2 (23may)
You need to log in before you can comment on or make changes to this bug.