1011411 - Create a commenting system for the voting app.

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Tasos Katsoulas [:tasos]]

A commenting system will be added to the voting tool. This system will be similar to the system that already exists in the reports app.

Key features:
* Comments will be only visible to the eligible group of the poll.
* Users can comment before and after they cast their vote.
* Users can comment before or during a vote, but no comments can be added after the vote ends.
* Only admin and the owner of the comment can delete a comment.
* Email notifications will be received by all users commented so far, except from the user made the comment, on every submitted comment.
* UI should be identical to the commenting system of the reports app.
* There will be a checkbox in the poll creation page to disable/enable comments for the specific poll.

This is the minimum functionality. Additional bugs will/may follow to enhance the functionality of this system.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/04c0cceb087e211f9ff7c10b1bae8263301f5692
[bug 1011411] Base commenting system for the voting app.

https://github.com/mozilla/remo/commit/961f0c6da9d4c7a0e086590f7a5016de33be796c
[bug 1011411] Email notification for the commenting system.

https://github.com/mozilla/remo/commit/c758975a708c3e081bf67a466148c284adb426fe
[fix bug 1011411] Make voting email notifications opt-in.

https://github.com/mozilla/remo/commit/bad0cba50365ff2c5b7bf480d45304c4d60b4779
Merge pull request #762 from akatsoulas/1011411

[fix bug 1011411] Commenting system for the voting app.

Comment 2

[John Giannelos [:nemo-yiannis]]

There are a couple of thinks not working properly in stage.

* Comments are not visible after the voting period.

* Wrong message when submitting an empty comment form and have already voted:
** 2 messages show up: "You have submitted your vote"
** Should have said the comment form is empty instead

* Also when you post a comment and have already voted:
** 3 messages show up: "You have submitted your vote"

Here is an etherpad with the functional specs and some inline comments:
https://remo.etherpad.mozilla.org/voting-comments-functional-specs

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/e63c35138993d9ea0b82d49476c30da5a2aceb3d
[fix bug 1011411] Fixes in voting commenting system.

https://github.com/mozilla/remo/commit/15048e94f01044cb643e5c2e9ce4ff579fd357fb
Merge pull request #782 from akatsoulas/1011411

 [fix bug 1011411] Fixes in voting commenting system.

Comment 4

[John Giannelos [:nemo-yiannis]]

Verified in stage:

* Comments are visible to past polls
* Voting messages show up properly
* Comment messages show up properly
* Voting form validation errors render properly
* Comment form validation error renders properly
* Delete comment permissions now work as expected