1011419 - [Flame] Make userdata image be 2GB

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[:gerard-majax]

As far as I saw on the T2M-provided builds, the userdata partition is 2GB. However, currently, flame.mk defines a 1GB partition.

Comment 1

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/device-flame/pull/21

Please find attached the github pull request to fix the userdata partition size to 2GB.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 8423745 [details] [review]
Link to Github https://github.com/mozilla-b2g/device-flame/pull/21

The userdata size here and the size that I've calculated from what the phone reports are different. Can you double check your calculation?

Comment 3

[:gerard-majax]

(In reply to Michael Wu [:mwu] from comment #2)
> Comment on attachment 8423745 [details] [review]
> Link to Github https://github.com/mozilla-b2g/device-flame/pull/21
> 
> The userdata size here and the size that I've calculated from what the phone
> reports are different. Can you double check your calculation?

I may have not checked correctly this value :). What value did you got on your side ?

Comment 4

[:gerard-majax]

I see that device/qcom/msm8610/BoardConfig.mk from T2M/foxfone-one defines a value of 2214592512

Comment 5

[:gerard-majax]

Michael, maybe we should clone/switch to the t2m repo for device/qcom/msm8610/ since it defines the proper value?

Comment 6

[Michael Wu [:mwu]]

Using device/qcom/msm8610 as the device directory is really just abusing it. Let's not do it wrong.

2214592512 matches my calculated userdata partition size, so go for that.

FWIW, this is how I determine partition size on these devices:

# Find partition name to partition number mapping
ls -l /dev/block/partition/msm_sdcc.1/by-name

# Then find the size of our partition
cat /proc/partitions

# Multiply the block count by 1024 to find the size in bytes

Comment 7

[:gerard-majax]

(In reply to Michael Wu [:mwu] from comment #6)
> Using device/qcom/msm8610 as the device directory is really just abusing it.
> Let's not do it wrong.
> 

So you prefer that we keep cherry-picking patches from partner's repo ? That's fine by me, it just makes quite a couple of more work :)

Comment 8

[:gerard-majax]

Comment on attachment 8423745 [details] [review]
Link to Github https://github.com/mozilla-b2g/device-flame/pull/21

Updated PR with the correct value.

Comment 9

[Carsten Book [:Tomcat]]

master : https://github.com/mozilla-b2g/device-flame/commit/b99bd353c9a1e292a21e686f2d6b35aafa1d06ca