about:networking Autorefresh checkbox and text not enclosed in a <label>

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mardeg, Assigned: hunboy)

Tracking

Trunk
mozilla32
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: goodfirstbug)

Attachments

(1 attachment)

Reporter

Description

5 years ago
Currently the line of code for the Autorefresh feature in about:networking is
<input type="checkbox" id="autorefcheck" name="Autorefresh"/>Autorefresh every 3 seconds

Located at http://mxr.mozilla.org/mozilla-central/source/toolkit/content/aboutNetworking.xhtml#37

It should be
<label><input type="checkbox" id="autorefcheck" name="Autorefresh"/>Autorefresh every 3 seconds</label>

Expected results: Clicking on the text "Autorefresh every 3 seconds" should toggle the checkbox

Actual results: Clicking text for the checkbox should toggle the checkbox
Assignee

Updated

5 years ago
Assignee: nobody → utasir
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86 → All
Assignee

Comment 1

5 years ago
Posted patch patch v1.0Splinter Review
who is the good requester for this patch?
Assignee

Comment 2

5 years ago
requester = reviewer/mentor ☺
Assignee

Updated

5 years ago
Attachment #8424279 - Flags: review?(ttaubert)
Comment on attachment 8424279 [details] [diff] [review]
patch v1.0

Review of attachment 8424279 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8424279 - Flags: review?(ttaubert) → review+
Assignee

Updated

5 years ago
Keywords: checkin-needed
Whiteboard: goodfirstbug → goodfirstbug

Comment 4

5 years ago
remote:   https://hg.mozilla.org/integration/fx-team/rev/ece88e3d2ebf
Keywords: checkin-needed
Whiteboard: goodfirstbug → [fixed in fx-team] goodfirstbug
https://hg.mozilla.org/mozilla-central/rev/ece88e3d2ebf
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team] goodfirstbug → goodfirstbug
Target Milestone: --- → mozilla32
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.