Closed Bug 1011458 Opened 6 years ago Closed 6 years ago

Shorten test package stage path name

Categories

(Testing :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: jgraham, Assigned: jgraham)

References

Details

Attachments

(1 file)

It turns out that on Windows the short path name limit makes every character precious. This means that test-package-stage is problematically long and had to be cut short in order to work with web-platform-tests without having an entirely unreasonable upstream path length limit, or confusingly short names for other parts of the web-platform-tests path. Cutting it down to test-stage saves 10 precious characters for little loss in readability.
Attachment #8423811 - Flags: review?(ted)
Thank you got filing this :-)
For
Comment on attachment 8423811 [details] [diff] [review]
Buy back a few characters for Windows paths by renaming tests staging directory.

Review of attachment 8423811 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/browser/browser_webapps_perms_reinstall.js
@@ +131,5 @@
>    let devPath = ["_tests", "testing", "mochitest",
>                   "browser", "dom" , "tests", "browser"];
>    // make package-tests moves tests to:
> +  // dist/test-stage/mochitest/browser/dom/tests/browser
> +  let slavePath = ["dist", "test-stage", "mochitest",

Wow, this is horrible.
Attachment #8423811 - Flags: review?(ted) → review+
Assignee: nobody → james
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5acdf68ae43d
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Depends on: 1013453
You need to log in before you can comment on or make changes to this bug.