1011458 - Shorten test package stage path name

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[James Graham [:jgraham]]

It turns out that on Windows the short path name limit makes every character precious. This means that test-package-stage is problematically long and had to be cut short in order to work with web-platform-tests without having an entirely unreasonable upstream path length limit, or confusingly short names for other parts of the web-platform-tests path. Cutting it down to test-stage saves 10 precious characters for little loss in readability.

Comment 1

[James Graham [:jgraham]]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=7cd790e31d02

Comment 2

[James Graham [:jgraham]]

Attachment: Buy back a few characters for Windows paths by renaming tests staging directory.

Comment 3

[Ed Morley [:emorley]]

Thank you got filing this :-)

Comment 4

[Ed Morley [:emorley]]

For

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 8423811 [details] [diff] [review]
Buy back a few characters for Windows paths by renaming tests staging directory.

Review of attachment 8423811 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/browser/browser_webapps_perms_reinstall.js
@@ +131,5 @@
>    let devPath = ["_tests", "testing", "mochitest",
>                   "browser", "dom" , "tests", "browser"];
>    // make package-tests moves tests to:
> +  // dist/test-stage/mochitest/browser/dom/tests/browser
> +  let slavePath = ["dist", "test-stage", "mochitest",

Wow, this is horrible.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5acdf68ae43d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5acdf68ae43d