Closed Bug 1011465 Opened 8 years ago Closed 8 years ago

Cleanup toolkit/webapps tests

Categories

(Firefox Graveyard :: Web Apps, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 32

People

(Reporter: marco, Assigned: marco)

Details

Attachments

(1 file)

We've added several tests lately, we can move the shared code to head.js.

This patch introduces a TestAppInfo class that contains the necessary info about the app (installPath, installedFiles, updatedFiles, etc.).

This should also make it simpler to write tests involving multiple apps.
Attachment #8423808 - Flags: review?(tabraldes)
Comment on attachment 8423808 [details] [diff] [review]
toolkit_webapps_tests_cleanup

Review of attachment 8423808 [details] [diff] [review]:
-----------------------------------------------------------------

I assume you've run these tests locally and on the try server to make sure landing this patch won't burn the tree
Attachment #8423808 - Flags: review?(tabraldes) → review+
(In reply to Tim Abraldes [:TimAbraldes] [:tabraldes] from comment #1)
> I assume you've run these tests locally and on the try server to make sure
> landing this patch won't burn the tree

Yes ;)

https://hg.mozilla.org/integration/mozilla-inbound/rev/be0dd45203f6
https://hg.mozilla.org/mozilla-central/rev/be0dd45203f6
Assignee: nobody → mar.castelluccio
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.