Closed Bug 1011478 Opened 6 years ago Closed 5 years ago

Disable browser.shell.checkDefaultBrowser also in DEBUG builds

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julienw, Assigned: julienw)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
rickychien
: review+
Details | Review
Currently, we set browser.shell.checkDefaultBrowser for DESKTOP=1 builds, but this should be set for all DEBUG=1 builds.
Attached file github PR
(not requesting review yet as I couldn't test properly the patch yet)
Pushed an updated version.
Comment on attachment 8423830 [details] [review]
github PR

Hey Ricky, what do you think ? :)

This is bugging me for _months_ :D
Attachment #8423830 - Flags: review?(ricky060709)
Comment on attachment 8423830 [details] [review]
github PR

LGTM. r+
Attachment #8423830 - Flags: review?(ricky060709) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.