Closed Bug 1011533 Opened 7 years ago Closed 7 years ago

Update ShapeCurve's state in onLayout instead of onMeasure

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 32

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(1 file)

A view can measured multiple times but onLayout() is always called only once in a layout traversal.
Comment on attachment 8423910 [details] [diff] [review]
Update ShapeCurve's path in onSizeChanged instead of onMeasure (r=bnicholson)

Doing it in onSizeChanged() which is only called when size has actually changed in the View's layout() call.
Attachment #8423910 - Flags: review?(bnicholson)
Blocks: 1010739
Comment on attachment 8423910 [details] [diff] [review]
Update ShapeCurve's path in onSizeChanged instead of onMeasure (r=bnicholson)

Review of attachment 8423910 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.
Attachment #8423910 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/c776f7bf62ad
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
You need to log in before you can comment on or make changes to this bug.