Closed Bug 1011558 Opened 10 years ago Closed 10 years ago

[SMS] Attachment download indicator: improve localization comments

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S2 (23may)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 file)

Pull request on GH
46 bytes, text/x-github-pull-request
julienw
: review+
Details | Review 
https://github.com/mozilla-b2g/gaia/commit/ac4309e47c4e454aed395c78225bc497cc2e9d54

The final comments are a bit confusing. I'm going to take a stab at rewriting them
Attached file Pull request on GH — 
Got feedback offline on IRC on these changes from Théo and Pike.

Julien, can you take a look?
Attachment #8423991 - Flags: review?(felash)
Comment on attachment 8423991 [details] [review]
Pull request on GH

looks good, thanks !

r=me
Attachment #8423991 - Flags: review?(felash) → review+
Thanks, setting keyboard for check-in.
Status: NEW → ASSIGNED
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/2255eda7dcd66cd84b1101ce9548ac6cfcb0b35c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.0: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S2 (23may)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: