1011660 - Stop having a separate DOMClass struct

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky, bz on IRC]]

With the patch in bug 1010658, the only thing holding a pointer to DOMClass is the DOMJSClass.  So we should just be able to move the DOMClass fields into DOMJSClass.

Peter, any obvious reasons not to do that?

Comment 1

[Peter Van der Beken [:peterv]]

I don't think so, let's do it.

Comment 2

[Eric Faust [:efaust]]

Attachment: Remove DOMClass

I left DOMClass in Codegen.py, since although we don't need a seperate struct, we still need to gen the same data in both proxy and non-proxy classes.

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 8434665 [details] [diff] [review]
Remove DOMClass

>-        {
>           { ${protoChain} },

Does the indent end up correct in the generated code?  Or do you need to outdent by 2 here?

r=me for whichever version makes the indent right.

Comment 4

[Eric Faust [:efaust]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6b74b7b4995

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f6b74b7b4995