Closed Bug 1011660 Opened 5 years ago Closed 5 years ago

Stop having a separate DOMClass struct

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: bzbarsky, Assigned: efaust)

Details

Attachments

(1 file)

With the patch in bug 1010658, the only thing holding a pointer to DOMClass is the DOMJSClass.  So we should just be able to move the DOMClass fields into DOMJSClass.

Peter, any obvious reasons not to do that?
Flags: needinfo?(peterv)
I don't think so, let's do it.
Flags: needinfo?(peterv)
Attached patch Remove DOMClassSplinter Review
I left DOMClass in Codegen.py, since although we don't need a seperate struct, we still need to gen the same data in both proxy and non-proxy classes.
Attachment #8434665 - Flags: review?(bzbarsky)
Comment on attachment 8434665 [details] [diff] [review]
Remove DOMClass

>-        {
>           { ${protoChain} },

Does the indent end up correct in the generated code?  Or do you need to outdent by 2 here?

r=me for whichever version makes the indent right.
Attachment #8434665 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/f6b74b7b4995
Assignee: nobody → efaustbmo
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.