Closed Bug 1011757 Opened 12 years ago Closed 12 years ago

Add aero styles for web audio editor

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

Product:
DevTools Graveyard
Component:
Web Audio Editor
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox30 unaffected, firefox31 affected, firefox32 affected)

Status:
RESOLVED FIXED
Milestone:
Firefox 32
Tracking Flags:
Tracking Status
firefox30 --- unaffected
firefox31 --- affected
firefox32 --- affected

People

(Reporter: jsantell, Assigned: jsantell)

Details

Attachments

(1 file, 2 obsolete files)

1011757-add-aero-styles-for-web-audio-editor.patch
2.33 KB, patch
jsantell
: review+
Details | Diff | Splinter Review
No description provided.
Added aero for the icon, not the styles unfortunately.
Assignee: nobody → jsantell
Attachment #8424206 - Flags: review?(vporof)
Attachment #8424206 - Flags: feedback?(scrapmachines)
Comment on attachment 8424206 [details] [diff] [review] 1011757-add-aero-styles-for-web-audio-editor.patch Review of attachment 8424206 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/themes/windows/jar.mn @@ +636,5 @@ > * skin/classic/aero/browser/devtools/scratchpad.css (devtools/scratchpad.css) > * skin/classic/aero/browser/devtools/shadereditor.css (devtools/shadereditor.css) > * skin/classic/aero/browser/devtools/splitview.css (../shared/devtools/splitview.css) > skin/classic/aero/browser/devtools/styleeditor.css (../shared/devtools/styleeditor.css) > +* skin/classic/aero/browser/devtools/webaudioeditor.css (../shared/devtools/webaudioeditor.css) ../shared/devtools/webaudioeditor.css does not exists. You should simply use devtools/webaudioeditor.css
Attachment #8424206 - Flags: review?(vporof)
Attachment #8424206 - Flags: feedback?(scrapmachines)
(or.... get rid of themes/*/devtools/webaudioeditor.css and rename themes/shared/devtools/webaudioeditor.inc.css to webaudioeditor.css and import ../shared/devtools/webaudioeditor.css in all three jar.mn and remove the * from each entry)
Fixed!
Attachment #8424206 - Attachment is obsolete: true
Attachment #8424221 - Flags: review?(vporof)
Attachment #8424221 - Flags: feedback?(scrapmachines)
Comment on attachment 8424221 [details] [diff] [review] 1011757-add-aero-styles-for-web-audio-editor.patch Review of attachment 8424221 [details] [diff] [review]: ----------------------------------------------------------------- This should also be uplifted to aurora
Attachment #8424221 - Flags: feedback?(scrapmachines) → feedback+
The aurora (31) version of web audio editor tools are much different than this, not too sure we should worry about it as it's really rough and shouldn't be promoted
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #6) > The aurora (31) version of web audio editor tools are much different than > this, not too sure we should worry about it as it's really rough and > shouldn't be promoted How does it matter what are the contents of the file? The aero entry is missing in aurora's jar.mn file, so this patch will just add it back.
Fair enough!
Attachment #8424221 - Flags: review?(vporof) → review+
Attachment #8425050 - Flags: review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/fx-team/rev/c0eb52b7bb49
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/c0eb52b7bb49
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: