1011763 - push_printurls.py for post-push hook should work on full repo path and not on basename only

Status: RESOLVED DUPLICATE of bug 1190494

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Over on bug 1010563 I added some QA hg repositories, which should print the cset for pushes via the post-push hook. I also wanted to add our puppet fork from build/puppet but that actually would give a problem because the repository keys would have the same name. So what-ever comes last in the config will be printed. That way you get an unexpected behavior when pushing to qa/puppet now:

pushing to ssh://hg.mozilla.org/qa/puppet
searching for changes
[..]
remote: You can view your change at the following URL:
remote:   https://hg.mozilla.org/build/puppet/rev/4709ac79bf99

We should update the code inside of the hook to not strip the whole path but keep the full path:

> repo_name = os.path.basename(repo.root)

Not sure if that would have some negative implications. Hal and Callek weren't able to remember why we are not doing that at the moment.

Comment 1

[Hal Wine [:hwine] use NI!]

<begin_hand_waving>
Let's shoot this whitelist in the head -- it needs tweaking every time a new branch is created. With b2g that's at least every 12 weeks, and there's just no known reason not to do this everywhere.

On the off chance that some process somewhere melts into a pile of rubble, I think flipping the definitions to a blacklist against the full repo path would be the second best approach.
</begin_hand_waving>

Comment 2

[Gregory Szorc [:gps]]

This got fixed in bug 1190494.