1011810 - ICCManager.getIccById is declared as returning "nsISupports" but can return null

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is causing the patch in bug 1008236 to fail, of course, since it asserts that actual return types match claimed ones.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Return the right type from getIccById

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Return the right type from getIccById

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8424276 [details] [diff] [review]
Return the right type from getIccById

Oh, we can't return nsISupports anymore if there is some real webidl type defined?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Olli Pettay [:smaug] from comment #3) 
> Oh, we can't return nsISupports anymore if there is some real webidl type
> defined?
Or that was just an additional fix. '?' was the real fix

Comment 5

[Boris Zbarsky [:bzbarsky]]

> Or that was just an additional fix. '?' was the real fix

Precisely.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Thanks for the reviews!

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a6216f789ea

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This needs to be uplifted as well in order for me to uplift bug 1004458 since beta merges to b2g30 and B2G debug will burn otherwise.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Bug 1004458 doesn't depend on this patch.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1a6216f789ea