1011816 - Cannot make symbolic link .../dist/bin/modules/devtools/gcli/something: File exists

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Fun race condition, due to how things are defined in toolkit/devtools/gcli/Makefile.in

I got the case with something = util.

The Makefile reads (only pasting the relevant things for util, but the problem is the same for others):

gcli_util_FILES = $(wildcard $(srcdir)/source/lib/gcli/util/*)
gcli_util_DEST = $(FINAL_TARGET)/modules/devtools/gcli/util
INSTALL_TARGETS += gcli_util

gcli_root_FILES = $(wildcard $(srcdir)/source/lib/gcli/*)
gcli_root_DEST = $(FINAL_TARGET)/modules/devtools/gcli
INSTALL_TARGETS += gcli_root

In the end, that makes $(srcdir)/source/lib/gcli/util be in gcli_root_FILES, and attempted to be installed as $(FINAL_TARGET)/modules/devtools/gcli/util, which, if the other rules finished first, exists as a directory, which makes nsinstall fail.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Avoid install targets race condition in toolkit/devtools/gcli

While at it, convert the libs:: rule to install targets

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6cbe36be19c2

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6cbe36be19c2