Closed
Bug 1012220
Opened 10 years ago
Closed 10 years ago
Make layout/reftests/css-*valid/textarea tests unfuzzy
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: smontagu, Assigned: smontagu)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
17.28 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
I found in bug 421436 that removing the 1-app-unit width from <br> makes a small difference to the same pixels marked as fuzzy in these tests. On Windows XP the difference goes as high as 64, unlike what I wrote in bug 421436 comment 7. (https://tbpl.mozilla.org/php/getParsedLog.php?id=39729294&tree=Try). I could turn up the fuzz knob as I did in the diff in that try run, but since it doesn't seem relevant to what these tests are testing, I think it would be cleaner to just remove the border from all the textareas in these tests, and also remove the fuzz. Try run: https://tbpl.mozilla.org/?tree=Try&rev=f7297b7a15c9
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8424453 -
Flags: review?(matt.woodrow)
Updated•10 years ago
|
Attachment #8424453 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/71581f8cf0d3
https://hg.mozilla.org/mozilla-central/rev/71581f8cf0d3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•