Closed Bug 1012497 Opened 7 years ago Closed 7 years ago

[Build System] Add GAIA_DEVICE_TYPE flag in Android.mk.

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: GaryChen, Assigned: GaryChen)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1010128 +++

Due to Gaia will be remove the distribution_tablet folder, so we need to set GAIA_DEVICE_TYPE for correct distribution.

Add GAIA_DEVICE_TYPE flag in Android.mk.
Assignee: nobody → gchen
Blocks: 1010128
No longer depends on: 1010128
Hi Marco and Yuren,
   Please help to review this patch and give me some feedback.

   Thanks.
Attachment #8424534 - Flags: review?(yurenju.mozilla)
Attachment #8424534 - Flags: review?(mchen)
Comment on attachment 8424534 [details]
pull request: https://bugzilla.mozilla.org/show_bug.cgi?id=1012497

Leave a comment on github and looks good to me.
Attachment #8424534 - Flags: review?(mchen) → feedback+
Hi Marco,
   I've address your comment, please help to review this patch again.
   Thanks.
Attachment #8424534 - Attachment is obsolete: true
Attachment #8424534 - Flags: review?(yurenju.mozilla)
Attachment #8424582 - Flags: review?(mchen)
Comment on attachment 8424582 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/19356

Hi Gary,

It looks good to me but I just can give feedback+ (I am not peer of gaia build system). Could you find another peer for review? Thanks.
Attachment #8424582 - Flags: review?(mchen) → feedback+
Comment on attachment 8424582 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/19356

Hi Yuren,
   Please help to review this patch.
   Thanks.
Attachment #8424582 - Flags: review?(yurenju.mozilla)
(In reply to Marco Chen [:mchen] from comment #4)
> Comment on attachment 8424582 [details] [review]
> pull request: https://github.com/mozilla-b2g/gaia/pull/19356
> 
> Hi Gary,
> 
> It looks good to me but I just can give feedback+ (I am not peer of gaia
> build system). Could you find another peer for review? Thanks.

Okay!
Thanks a lots.
Comment on attachment 8424582 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/19356

I don't know much about Android.mk, I think Michael Wu is the right person to review it.
Attachment #8424582 - Flags: review?(yurenju.mozilla) → review?(mwu)
Attachment #8424582 - Flags: review?(mwu) → review+
landed in master:
https://github.com/mpizza/gaia/commit/3bbe76bec3d321021c5d26bc3fbe018dfd3fc649

travis got green:
https://travis-ci.org/mozilla-b2g/gaia/builds/25488737
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.