1012508 - Add a admin_menu hook to change who has access to admin.cgi

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Simon Green]

We have template hooks in t/e/d/admin/admin.html.tmpl to add extra items to the admin menu, but that requires that the new option uses one of the existing privileges.

This change allows an extension code to change whether a user can see admin.cgi or not.

Comment 1

[Simon Green]

Attachment: bug1012508-v1.patch

dkl is excluded from reviewing since this is brc code from before my time. He may or may not have written or reviewed the change.

Comment 2

[Simon Green]

Attachment: bug1012508-v1.patch

Comment 3

[Simon Green]

Comment on attachment 8424572 [details] [diff] [review]
bug1012508-v1.patch

I'm revoking this patch, as it can be done better. Currently the rules are also duplicated in common-links.html.tmpl. So will create a new function in Bugzilla::User that does this once.

Comment 4

[Simon Green]

Attachment: bug1012508-v1.patch

Okay. Third crack at my first patch. This does it much better IMO.

Comment 5

[Gervase Markham [:gerv]]

Comment on attachment 8439689 [details] [diff] [review]
bug1012508-v1.patch

Review of attachment 8439689 [details] [diff] [review]:
-----------------------------------------------------------------

With the name changes, r=gerv.

Gerv

::: Bugzilla/User.pm
@@ +1446,4 @@
>      return [ sort { $a->name cmp $b->name } values %products ];
>  }
>  
> +sub can_see_admin {

I'd call this can_administer.

::: extensions/Example/Extension.pm
@@ +31,4 @@
>  
>  our $VERSION = '1.0';
>  
> +sub admin_menu {

This makes it sound like the hook allows you to add to the admin menu. I'd go for user_can_administer (hooks often seem to be prefixed with category or object names).

Comment 6

[Simon Green]

To ssh://[e-mail]/bugzilla/bugzilla.git
   6c6efdd..80c434b  master -> master