Closed Bug 1012520 Opened 10 years ago Closed 10 years ago

[Keyboard] Remove mCalls from the mock mozSettings impl

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S2 (23may)

People

(Reporter: timdream, Assigned: timdream)

References

Details

Attachments

(1 file)

mozilla-b2g:master PR#19360
46 bytes, text/x-github-pull-request
rudyl
: review+
Details | Review 
+++ This bug was initially created as a clone of Bug #1005751 +++

I figured out a way to not create mCalls array in the mozSettings mock.
Target Milestone: --- → 2.0 S2 (23may)
Attachment #8424587 - Flags: review?(rlu)
Comment on attachment 8424587 [details] [review]
mozilla-b2g:master PR#19360

Looks pretty good to me.
Thanks.
Attachment #8424587 - Flags: review?(rlu) → review+
master: https://github.com/mozilla-b2g/gaia/commit/17da68db9f9fa777fa3cb769cb9e6c80143e3d52
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: