1012545 - [DSDS] SIM label on Dial button highlighted when tapping the add number button and no number in the text field

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: CallLongSimLabel.png

### STR
1. Open Dialer in a DS phone.
2. Do not enter any number, leave the text field empty.
3. Tap the add number icon.
4. <ISSUE> SIM label on Dial button highlighted.

### Actual
SIM label on Dial button highlighted.

### Expected
Nothing happen.

### Version
Flame v2.0
Gaia      101c500903a2477f9de1ea5ce523b9e0be4d45d0
Gecko     https://hg.mozilla.org/mozilla-central/rev/41a54c8add09
BuildID   20140518160203
Version   32.0a1

Dolphine v2.0 
Gaia      9f1a9ef00f71f7ce0c7e6fedba4bee2b721d7686
Gecko     2ff2afa66e5cae7f6c3cf3f4d2324eb332ef34b7
BuildID   20140519053053             
Version   32.0a1

Comment 1

[Eric Chang [:ericcc] [:echang]]

Hi, Etienne, Could you take a look at this, thank you.

Comment 2

[Etienne Segonzac (:etienne)]

Yep I can reproduce the issue.

Comment 3

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

2 issues:
* when trying to reproduce this bug the (disabled) add-contact button was constantly triggering a '*' key press then the add contact menu (with one gesture :/)
* the whole keypad-callbar was receiving events which caused a full repaint (and eventually the rendering issue of this bug).

I'll let you try it it's much better like this.

Comment 4

[Anthony Ricaud (:rik)]

Comment on attachment 8424875 [details] [review]
Gaia PR

Bug 990462 is the first issue you noticed. Gabriele will be happy that you found the root cause ;)

Per IRL discussion, we need to put a pointer-events: all because building blocks add a pointer-events: none.

Comment 6

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/88f857275154f0161dd6a5ceb57a3ce0e4e2d6d3

Comment 7

[Eric Chang [:ericcc] [:echang]]

Works okay with these 2 builds.
Flame Aurora v2.0
Gaia      1dd043857399c713e3b509c0ed31bdf20326f08b
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/3f9d7a3a0b7b
BuildID   20140707160206
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Flame Master v2.1
Gaia      e935f4ff190b76c70d9b2af8856c542a6e4a7546
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/3f9d7a3a0b7b
BuildID   20140707160206
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220