1012568 - replace all tab to 2 spaces in Makefile except makefile rules.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

we should use two spaces instead of tab in Makefile except rules of Makefile.

Comment 1

[Projjol [:dorsatum]]

Attachment: Changes indentation from 4 tab spaces to 2 spaces

I'd like to work on this work and for it, I've attached a proposed pull request.

Comment 2

[Nathan Yee [:nyee]]

Is this bug still an issue? Projjol's attachment as of now appears to have failed its pull request.

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

yes it's still an issue, feel free to ask me question with needinfo flag (click check box "Need more information from" and my email [e-mail])

Comment 4

[Nathan Yee [:nyee]]

How should I test if my changes are working (e.g. run make or something else)?

Comment 5

[Nathan Yee [:nyee]]

Reminder message for the above.

Comment 6

[Sudheesh Singanamalla (:ShellHacker)]

Setting a flag to help Nathan.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Nathan, we have integraion and unit test for gaia build system, in your case you should use integration test to verify it: |make build-test-integraion|

thanks Suhdheesh :)

Comment 8

[Nathan Yee [:nyee]]

Although my patch seems to be correct, I am not a Makefile expert, so I don't know for certain. However, I can try submitting my patch if necessary. Should I upload my patch or defer this bug to someone else?

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi Nathan, please send a pull request, add a attachment and use "paste text as attachment" to attach your pull request link.

Comment 10

[Nathan Yee [:nyee]]

Attachment: bug-1012568-fix

This is the most correct I've made this patch so far. Please comment about any other changes that need to be made.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8474586 [details] [review]
bug-1012568-fix

:nyee, only one nit, otherwise looks great!

please fix the nit I mentioned on github, rebase and send me review again.

thanks!

Comment 12

[Nathan Yee [:nyee]]

Attachment: bug-1012568-fix [v.2]

Comment 13

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8477181 [details] [review]
bug-1012568-fix [v.2]

looks great! r=yurenju

this pull request need to be rebased, please 
1. squash to one commit
2. rebase to last master branch

if you are not familiar with git, there are two videos to show how to do it.
rebase: https://asciinema.org/a/11316
squash: https://asciinema.org/a/11269

please needinfo? me if you have updated pull request which is rebased and squashed.

Comment 14

[Nathan Yee [:nyee]]

Attachment: bug-1012568-fix [v.3]

Comment 15

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

:nyee, gaia tree is closed now since we have a test "app_uninstall_test.js" is always failed.

I will notice you when gaia tree open again.

Comment 16

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

:nyee, gaia tree is opened, can you rebase and push again?

Comment 17

[Nathan Yee [:nyee]]

Attachment: bug-1012568-fix [v.4]

Done.

Comment 18

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8479580 [details] [diff] [review]
bug-1012568-fix [v.4]

:nyee, we removed rule "app-makefile" on bug 1029385 but it added back in your commit on lin 502~516, please remove them, otherwise looks good.

Comment 19

[Nathan Yee [:nyee]]

Attachment: bug-1012568-fix [v.5]

Done.

Comment 20

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8479612 [details] [review]
bug-1012568-fix [v.5]

that looks good! waiting result on try server to land it! r=yurenju

Comment 21

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Run Gij twice and got different errors
* [system] browser_chrome_share_web_result_test.js
* [calendar] day_view_test.js

seems intermittent issues for integration test and this change is only replace all tab to 2 spaces in Makefile, so merged.

thanks for the contribution!

https://github.com/mozilla-b2g/gaia/commit/c3f6c3f6463c54bec3e2d8af0b11792fc9481a5c