Closed Bug 1012578 Opened 8 years ago Closed 8 years ago

Create gaia-grid component

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S2 (23may)
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [p=4],[systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
amirn
: review+
crdlc
: review+
daleharvey
: feedback+
Details | Review
The new vertical homescreen has a collection of files related to grid rendering. We should abstract these to shared/ so we can use the same rendering logic in several apps. The initial apps that will use these libraries:

 - Homescreens
 - Collections
 - Search
Attached file Github pull request
Comment on attachment 8424847 [details] [review]
Github pull request

Hey Dale, Amir - 

Would be good to get a review pass from you guys if you have the time. Thanks!
Attachment #8424847 - Flags: review?(dale)
Attachment #8424847 - Flags: review?(amirn)
Comment on attachment 8424847 [details] [review]
Github pull request

Also adding Cristian for review here. Lots of moving pieces, will likely conflict with any in-progress work. I will gladly help resolve any conflicts, so just let me know.
Attachment #8424847 - Flags: review?(crdlc)
I think this is the relevant gaia-try run: https://tbpl.mozilla.org/?tree=Gaia-Try&showall=1&rev=7e90237d9935
Comment on attachment 8424847 [details] [review]
Github pull request

This looks good to me, would be more comfortable with landing on crdlc's review as I still learning about the homescreen, will get on wit hthe search implementation
Attachment #8424847 - Flags: review?(dale) → feedback+
Comment on attachment 8424847 [details] [review]
Github pull request

LGTM, good job!
Attachment #8424847 - Flags: review?(crdlc) → review+
Thanks for the review. It may be useful to track this work with the other components, so I'm going to block bug 1002417 with this work. I don't think this will be a meta or anything though.
Alias: gaia-grid
Summary: Abstract grid rendering logic for use in multiple apps → Create gaia-grid component
Look great!
Attachment #8424847 - Flags: review?(amirn) → review+
Alias: gaia-grid
No longer blocks: gaia-web-components
Whiteboard: [p=2],[systemsfe] → [p=4],[systemsfe]
Landed: https://github.com/mozilla-b2g/gaia/commit/41b482a81980de059180281905d92d13b9986af3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.