Closed Bug 1012653 Opened 10 years ago Closed 10 years ago

[FM] Remove inline style for CSP compliance

Categories

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::FMRadio
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gerard-majax, Assigned: vingtetun)

References

Details

Attachments

(1 file)

csp.fm.patch
3.22 KB, patch
timdream
: review+
Details | Diff | Splinter Review 
Confere bug 968907 and bug 858787. We need to remove all CSS inline usage in certified apps.

https://github.com/mozilla-b2g/gaia/blob/master/apps/fm/js/fm.js
Depends on: 817674
Attached patch csp.fm.patch — — Splinter Review 
Pretty small changes.
Attachment #8437319 - Flags: review?(lissyx+mozillians)
It looks okay but I'm not peer of this module, I can't stamp a review for this :)
Comment on attachment 8437319 [details] [diff] [review]
csp.fm.patch

Let's ask to Tim then.
Attachment #8437319 - Flags: review?(lissyx+mozillians) → review?(timdream)
Attachment #8437319 - Flags: review?(timdream) → review+
Try is green. https://github.com/mozilla-b2g/gaia/commit/626a32edd99697e721aa72a05600feb959c7edd7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: