1012659 - [Settings] Remove inline style for CSP compliance

Status: RESOLVED DUPLICATE of bug 1023682

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[:gerard-majax]

Confere bug 968907 and bug 858787. We need to remove all CSS inline usage in certified apps.

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/app_permissions.html#L18

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: csp.settings.patch

This part of settings is never displayed...

Comment 2

[:gerard-majax]

It looks okay but I'm not peer of this module, I can't stamp a review for this :)

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8437332 [details] [diff] [review]
csp.settings.patch

Review of attachment 8437332 [details] [diff] [review]:
-----------------------------------------------------------------

Let's ask to Arthur then.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8437332 [details] [diff] [review]
csp.settings.patch

Review of attachment 8437332 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for cleaning the style and catching the bug. I've filed bug 1023682 tracking the issue.

::: apps/settings/elements/app_permissions.html
@@ -12,5 @@
>        <ul class="app-list"></ul>
>  
>        <ul>
>          <li>
>            <button id="clear-bookmarks-app"

There should not be id in a panel. Could you help remove it while you are on it?

@@ -14,5 @@
>        <ul>
>          <li>
>            <button id="clear-bookmarks-app"
>                    class="clear-bookmarks-app"
> -                  style="visibility: hidden"

Please use a "hidden" attribute.