1012735 - Use HeapCopyOfStackArray for the fBufferData call in nsChildView.mm

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

This is the buffering of the quad that we use with BasicCompositor on Mac to present the basic composition result to the screen.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8424914 [details] [diff] [review]
v1

Review of attachment 8424914 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsChildView.mm
@@ +2912,5 @@
> +                          verticesOnHeap.ByteLength(),
> +                          verticesOnHeap.Data(),
> +                          LOCAL_GL_STATIC_DRAW);
> +   mGLContext->fBindBuffer(LOCAL_GL_ARRAY_BUFFER, 0);
> +

Extra line of whitespace here.

Comment 2

[Matt Woodrow (:mattwoodrow)]

checkin-needed?

Comment 3

[Markus Stange [:mstange]]

oops! checkin-incoming.

Comment 4

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a812cce3895

Comment 5

[Markus Stange [:mstange]]

and https://hg.mozilla.org/integration/mozilla-inbound/rev/9db1e2f6d026 for the whitespace fix (addresses comment 1)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a812cce3895
https://hg.mozilla.org/mozilla-central/rev/9db1e2f6d026