Closed Bug 1012735 Opened 7 years ago Closed 7 years ago

Use HeapCopyOfStackArray for the fBufferData call in nsChildView.mm

Categories

(Core :: Graphics: Layers, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file)

Attached patch v1Splinter Review
This is the buffering of the quad that we use with BasicCompositor on Mac to present the basic composition result to the screen.
Attachment #8424914 - Flags: review?(bjacob)
Comment on attachment 8424914 [details] [diff] [review]
v1

Review of attachment 8424914 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsChildView.mm
@@ +2912,5 @@
> +                          verticesOnHeap.ByteLength(),
> +                          verticesOnHeap.Data(),
> +                          LOCAL_GL_STATIC_DRAW);
> +   mGLContext->fBindBuffer(LOCAL_GL_ARRAY_BUFFER, 0);
> +

Extra line of whitespace here.
Attachment #8424914 - Flags: review?(bjacob) → review+
checkin-needed?
oops! checkin-incoming.
https://hg.mozilla.org/mozilla-central/rev/7a812cce3895
https://hg.mozilla.org/mozilla-central/rev/9db1e2f6d026
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
No longer depends on: 1017256
You need to log in before you can comment on or make changes to this bug.