1012817 - non ascii code support in manifest

Status: VERIFIED FIXED

(Marketplace Graveyard :: Validation, defect, P2)

Description

[(not reading bugmail) Nick Desaulniers [:\n]]

I'm not sure what there error is here, but a developer was reporting a validation error [0].  They reported the following line from a stack trace which looks suspect:

"/data/mkt.prod/www/marketplace.firefox.com/current/venv/lib64/python2.6/re.py", line 151, in sub return _compile(pattern, 0).sub(repl, string, count) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 6: ordinal not in range(128)

Their manifest [1].

[0] https://marketplace.firefox.com/developers/upload/542ea04e42dc42a6b498b81dd1715883
[1] http://mozilla-albania.org/manifest.webapp

Comment 1

[Elio Qoshi [:Elio]]

Thank you Nick for the bug report.
I was working on our Mozilla Albania community page app when I encountered this error.
Seems this is not something from our end so we hope to get this fixed soon.

For any details regarding bug reports or tests let me know (I submitted the manifest specified by Nick)

Comment 2

[Mathieu Pillard [:mat]]

That manifest includes a BOM (https://en.wikipedia.org/wiki/Byte_order_mark) at the beginning of the file, which I'm not sure is supported. Regardless, we certainly shouldn't expose tracebacks like that when validating.

Comment 3

[Mathieu Pillard [:mat]]

As it turns out, the problem was not the manifest itself, but the validator choking on UTF-8 content on the launch_page, which it tries to parse. I've submitted https://github.com/mozilla/app-validator/pull/25 to fix this.

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/app-validator/commit/50ae334d74ca2e52efcc98baeb1b7e283d6d2c6a and https://github.com/mozilla/zamboni/commit/8f8a6560e1c83db819b10194d5989e65efee4e68

STR:
- Validate & submit an hosted app with this manifest: http://mozilla-albania.org/manifest.webapp

Comment 5

[(not reading bugmail) Nick Desaulniers [:\n]]

Elio, can you give resubmission a shot and let us know how it goes?

Comment 6

[krupa raj[:krupa]]

(In reply to Nick Desaulniers [:\n] from comment #5)
> Elio, can you give resubmission a shot and let us know how it goes?

Note that this fix is not in production yet. Please try submitting after 06/03.

However, the issue is fixed in dev. Verified fixed at https://marketplace-dev.allizom.org/developers/upload/d35e00c149584cdda3da601777c05cab

Comment 7

[Elio Qoshi [:Elio]]

Yeah, it gave me the same error message now, so I will check again in a week.