1012829 - HDPI support for developer toolbar

Status: RESOLVED FIXED

(DevTools :: General, defect)

Comment 1

[Tim Nguyen :ntim]

Brian, is this worth fixing ? We're gonna get rid of the developer toolbar soon according to what you said.

Comment 2

[Brian Grinstead [:bgrins]]

I don't think we necessarily need to worry about it.  The current icons are simple enough that they will scale alright to 2x, so we should be fine in the meantime.

Comment 3

[Tim Nguyen :ntim]

Attachment: Patch v1

Tested, no regressions/issues appearing.

Comment 4

[Tim Nguyen :ntim]

Pushed to try : https://tbpl.mozilla.org/?tree=Try&rev=78954de8a8c6

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8432725 [details] [diff] [review]
Patch v1

Review of attachment 8432725 [details] [diff] [review]:
-----------------------------------------------------------------

The UI looks good in 2x, but I'm getting an error applying the patch to the jar.mn files

::: browser/themes/shared/devtools/commandline.inc.css
@@ +157,5 @@
>  
> +.gclitoolbar-input-node::before {
> +  content: "";
> +  display: inline-block;
> +  -moz-box-ordinal-group: 0;

Why does this property need to be set here?

Comment 6

[Tim Nguyen :ntim]

(In reply to Brian Grinstead [:bgrins] from comment #5)
> Comment on attachment 8432725 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 8432725 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The UI looks good in 2x, but I'm getting an error applying the patch to the
> jar.mn files
Yeah, there are 2 HDPI related bugs awaiting to land that changed the jar.mn files (bug 1017890 and bug 1018809)

> ::: browser/themes/shared/devtools/commandline.inc.css
> @@ +157,5 @@
> >  
> > +.gclitoolbar-input-node::before {
> > +  content: "";
> > +  display: inline-block;
> > +  -moz-box-ordinal-group: 0;
> 
> Why does this property need to be set here?
I don't think it's needed, but it's nice to have in case a new children gets added inside the textbox. I'll remove it.

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8432725 [details] [diff] [review]
Patch v1

Review of attachment 8432725 [details] [diff] [review]:
-----------------------------------------------------------------

Joe, from a usage standpoint this patch is good (I've checked in 2x and things look nice and sharp).  But it'd be good if you could review the changes in commandline.inc.css

Comment 8

[Joe Walker [:jwalker]]

Comment on attachment 8432725 [details] [diff] [review]
Patch v1

Review of attachment 8432725 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good to me. I'd like to try it out. But that will have to wait until tomorrow

Comment 9

[Joe Walker [:jwalker]]

Comment on attachment 8432725 [details] [diff] [review]
Patch v1

Review of attachment 8432725 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks.

Comment 10

[Tim Nguyen :ntim]

Try push in comment 4.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/52f6d0a67991

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/52f6d0a67991