1012835 - App has no author

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P2)

Description

[Bill Walker [:bwalker] [@wfwalker]]

steps to reproduce:

1. get the JSON at https://marketplace.firefox.com/api/v1/apps/app/411324/

expected:

author field contains a string

actual:

author field is null

Comment 1

[Andy McKay]

The author field returns the addon author display name. Interestingly enough this app somehow has no user at all. It was uploaded on Dec 7, 2012 9:33:56 AM, which makes it old in terms of this site. 

Interestingly enough, the review history and edit history both crash when accessing unlike the API. So the API is good. Curious how we got to this state of affairs, but with an app that old, tempted to remove it at this point.
 
http://sentry.mktmon.services.phx1.mozilla.com/mkt/marketplacefirefoxcom/group/6701/

Comment 2

[Andy McKay]

Do you think we should pull this app off the marketplace, I feel bad because they were clearly an early adopter and its not their fault (I suspect), they ended with no author attached to the app.

https://marketplace.firefox.com/lookup/app/411324/summary

Comment 3

[Mathieu Pillard [:mat]]

app.author should use the developer name from the manifest, not the addon author display name, that fallback was removed some time ago. When we did that, I ran a command to update all developer names from manifests, it possible this app fell through the cracks though (either because its manifest was unreachable at the time, or because it was in a weird state to begin with)

It's definitely a problem to have an app without associated users though.

Comment 4

[Andrew Williamson [:eviljeff]]

(In reply to Andy McKay [:andym] from comment #2)
> Do you think we should pull this app off the marketplace, I feel bad because
> they were clearly an early adopter and its not their fault (I suspect), they
> ended with no author attached to the app.
> 
> https://marketplace.firefox.com/lookup/app/411324/summary

I'd rather not go deleting either - is the missing author that's causing the errors on the reviewer and edit pages?  If so, is it feasible to fix manually with some sql or whatever or would it have to be a new submission?

Comment 5

[Andrew Williamson [:eviljeff]]

fwiw, from the activity log https://marketplace.firefox.com/lookup/user/6747918/summary used to be the author but I can't see when he was removed.  His twitter account doesn't imply he's no-longer involved with the kiwiirc project.

Comment 6

[Andy McKay]

(In reply to Andrew Williamson [:eviljeff] from comment #4)
> I'd rather not go deleting either - is the missing author that's causing the
> errors on the reviewer and edit pages?  If so, is it feasible to fix
> manually with some sql or whatever or would it have to be a new submission?

We could assign it to a reviewer and they could work with the developer to figure out a plan.

Comment 7

[Andrew Williamson [:eviljeff]]

(In reply to Andy McKay [:andym] from comment #6)
> (In reply to Andrew Williamson [:eviljeff] from comment #4)
> > I'd rather not go deleting either - is the missing author that's causing the
> > errors on the reviewer and edit pages?  If so, is it feasible to fix
> > manually with some sql or whatever or would it have to be a new submission?
> 
> We could assign it to a reviewer and they could work with the developer to
> figure out a plan.

you can assign it to me then.  user 631.

Comment 8

[Andy McKay]

eviljeff is going to contact the author, if we change the slug, delete it and resubmit, we should get an app that's good. After fixing a few things on the app, of which none are the submitters fault, its still got no categories, screenshots or "file" object. The simplest way to clean all this app is to submit a new one.