1012860 - MSVC build warning: WidgetUtils.cpp(22) : warning C4305: 'argument' : truncation from 'double' to 'mozilla::gfx::Float'

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Daniel Holbert [:dholbert]]

Our TBPL Windows builds currently hit these build warnings:
{
c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\widget\xpwidgets\WidgetUtils.cpp(22) : warning C4305: 'argument' : truncation from 'double' to 'mozilla::gfx::Float'
c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\widget\xpwidgets\WidgetUtils.cpp(26) : warning C4305: 'argument' : truncation from 'double' to 'mozilla::gfx::Float'
c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\widget\xpwidgets\WidgetUtils.cpp(30) : warning C4305: 'argument' : truncation from 'double' to 'mozilla::gfx::Float'
}

I believe these are from passing M_PI (a #define for pi, implicitly a double) in to a function that accepts a gfx::Float (a float).

Filing this bug to fix these (by making the conversion explicit with static_cast.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Haven't tested this on Windows yet, but I expect this should fix the problem. Will request review after I've confirmed that.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v2

(just fixing a whitespace issue from earlier patch)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v3

Hooray -- the Try run is green, and 'grep' confirms that there are no warnings for xpwidgets in the log.

I'm posting this new version of the patch to fix the bug # in commit message (I copypasted the wrong bug # into the last one), and requesting review.

Comment 4

[Daniel Holbert [:dholbert]]

For the record, the Try run with this is: https://tbpl.mozilla.org/?tree=Try&rev=b3276cad96e9

(This bug's patch is the middle cset there -- mistakenly labeled in the commit message as being for bug 1012858)

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8425088 [details] [diff] [review]
fix v3

Review of attachment 8425088 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/xpwidgets/WidgetUtils.cpp
@@ +13,5 @@
>  ComputeTransformForRotation(const nsIntRect& aBounds,
>                                ScreenRotation aRotation)
>  {
>      gfx::Matrix transform;
> +    static gfx::Float floatPi = static_cast<gfx::Float>(M_PI);

static const

Comment 6

[Daniel Holbert [:dholbert]]

Will add 'const' before landing. Thanks!

Comment 7

[Daniel Holbert [:dholbert]]

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/2940750f68ea

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2940750f68ea