1013005 - Activating a contact via screen reader corrupts layout

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eitan Isaacson [:eeejay]]

Attachment: screenshot.png

I am not sure exactly what I am seeing.

STR:
1. Open contacts app.
2. Activate screen reader.
3. Select a contact and double tap.

Expected: Go to contact details.

Actual: The header disappears and the entire app jumps up. Also, the whole gecko instance seems to get corrupted. The #windows element seems to go to a negative offset, it looks like the length size of the status bar.

Comment 1

[Eitan Isaacson [:eeejay]]

This has to do with how we send click events via a11y API. I have pending patches in bug 1017322 and bug 1015379.

Nonetheless, if we use roles other than list/listitem in the contacts list. Perhaps listbox/option is more appropriate, then it would work around the issue in the two a11y bugs mentioned above.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19797

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8431249 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19797

\o/

At the begining was a bit confused by the use of those roles until I read this:

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_listbox_role

Thanks a lot!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

We are adding two classes, no need to add new unit test for that.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/eeejay/gaia/commit/7b7a37ea33c3e89b0f4cf38eb23a60cc35211dbc