1013006 - [AccessFu] isFlatSubtree returns false when there is an ancestor with a click listener

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Even if it is a simple subtree with text leaves, if an ancestor has a click listener, the text leaves will have an actionCount of 1 (while their direct parent won't). So it is not enough to check for actionCount 0, we need to verify the role, and make sure they are not text leaves or static text.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Ignore actionCount on text leaves when checking if the subtree is flat.

Comment 2

[Marco Zehe (:MarcoZ) [Currently out sick]]

Comment on attachment 8425164 [details] [diff] [review]
Ignore actionCount on text leaves when checking if the subtree is flat.

>+      // text leafs inherit the actionCount of any ancestor that has a click

Nit> Text leaves.

>+      if ([Roles.TEXT_LEAF, Roles.STATICTEXT].indexOf(child.role) >= 0) {

What the...

Umm...I mean, what kind of syntax is that? :-)

Comment 3

[Yura Zenevich [:yzen]]

Comment on attachment 8425164 [details] [diff] [review]
Ignore actionCount on text leaves when checking if the subtree is flat.

Review of attachment 8425164 [details] [diff] [review]:
-----------------------------------------------------------------

Nice

Comment 4

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37e1dd2155b6

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/37e1dd2155b6