1013078 - Remove some dead code left over from the removal of the Leaky tool

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

Bug 750290 removed Leaky, but that bug's patch missed some code.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove some dead code left over from the removal of the Leaky tool

The nsTraceRefcnt.cpp changes are straightforward.

As for libmalloc.h -- there are no definitions corresponding to those
declarations.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8425265 [details] [diff] [review]
Remove some dead code left over from the removal of the Leaky tool

If you're pruning libmalloc.h, could you also remove malloc_log_stack and the LIBMALLOC_* constants?

r=dbaron

Comment 3

[Nicholas Nethercote [inactive]]

> If you're pruning libmalloc.h, could you also remove malloc_log_stack and
> the LIBMALLOC_* constants?

Sure. I'll remove SetMallocFlags() too.

Comment 4

[Nicholas Nethercote [inactive]]

I moved the libmalloc.h changes into a separate patch:

https://hg.mozilla.org/integration/mozilla-inbound/rev/372ed56353b5
https://hg.mozilla.org/integration/mozilla-inbound/rev/47fbda634a67

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/372ed56353b5
https://hg.mozilla.org/mozilla-central/rev/47fbda634a67

Comment 6

[Mike Hommey [:glandium]]

You could remove leakyLog* from js/src/devtools/rootAnalysis/annotations.js

Comment 7

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Remove references to now-removed leakyLog*() functions in annotations.js

Part 1 (which has already landed) removed leakyLogAddRef() and
leakyLogRelease(). So the static analysis shouldn't need to worry about them
any more. (They were never actually used in practice, because nobody ever set
XPCOM_MEM_LEAKY_LOG, though I guess the static analysis couldn't determine
that.)

Comment 8

[Nicholas Nethercote [inactive]]

Oh, I forgot about part 3:

https://hg.mozilla.org/integration/mozilla-inbound/rev/85309cd801b8

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/85309cd801b8