Closed Bug 1013078 Opened 6 years ago Closed 6 years ago

Remove some dead code left over from the removal of the Leaky tool

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(2 files)

Bug 750290 removed Leaky, but that bug's patch missed some code.
The nsTraceRefcnt.cpp changes are straightforward.

As for libmalloc.h -- there are no definitions corresponding to those
declarations.
Attachment #8425265 - Flags: review?(dbaron)
Comment on attachment 8425265 [details] [diff] [review]
Remove some dead code left over from the removal of the Leaky tool

If you're pruning libmalloc.h, could you also remove malloc_log_stack and the LIBMALLOC_* constants?

r=dbaron
Attachment #8425265 - Flags: review?(dbaron) → review+
> If you're pruning libmalloc.h, could you also remove malloc_log_stack and
> the LIBMALLOC_* constants?

Sure. I'll remove SetMallocFlags() too.
https://hg.mozilla.org/mozilla-central/rev/372ed56353b5
https://hg.mozilla.org/mozilla-central/rev/47fbda634a67
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You could remove leakyLog* from js/src/devtools/rootAnalysis/annotations.js
Part 1 (which has already landed) removed leakyLogAddRef() and
leakyLogRelease(). So the static analysis shouldn't need to worry about them
any more. (They were never actually used in practice, because nobody ever set
XPCOM_MEM_LEAKY_LOG, though I guess the static analysis couldn't determine
that.)
Attachment #8428443 - Flags: review?(sphink)
Attachment #8428443 - Flags: review?(sphink) → review+
You need to log in before you can comment on or make changes to this bug.