Closed Bug 1013123 Opened 9 years ago Closed 9 years ago

Increase width of 'Enter a tag prefix' textbox for prefix of autotagged category names of feed articles

Categories

(MailNews Core :: Feed Reader, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 33.0

People

(Reporter: aryx, Assigned: aryx)

Details

Attachments

(1 file, 2 obsolete files)

Windows 8.1
Daily and Aurora

The feed subscription dialog has an option to autotag feed items with category elements and prefix these (bug 946279). Localizations of the placeholder text can be longer than the English text, so please increase the width of the textbox.

Example:

English: "Enter a tag prefix"
German: "Anfangstext für Schlagwörter eingeben", gets only shown as "Anfangstext für Schlagwör" and hasn't been uploaded yet
hmm, looks like the seamonkey translation is much shorter..  (but less good imo).

you can add a width="300" to the textbox if you like.
Attached patch patch, v1 (obsolete) — Splinter Review
One line patch as suggested by alta88.
Assignee: nobody → archaeopteryx
Status: NEW → ASSIGNED
Attachment #8443888 - Flags: review?(josiah)
Comment on attachment 8443888 [details] [diff] [review]
patch, v1

Review of attachment 8443888 [details] [diff] [review]:
-----------------------------------------------------------------

Could you do that with CSS instead? We're trying to slowly move away from this XUL/HTML 4 sizing and styling.
Attachment #8443888 - Flags: review?(josiah) → feedback+
Attached patch patch, v2 (obsolete) — Splinter Review
Attachment #8443888 - Attachment is obsolete: true
Attachment #8444145 - Flags: review?(josiah)
sorry for the nits, but.

1. 300 was selected precisely; it accomodates the longest string (Tb de), if you check localizations.. making this very large, or having it flex=1 the full width, doesn't look good as the value is certainly a very short token.

2. if you put it in css files, please note a better organization is to go outer to inner and top to bottom, box model element wise.  so i'd put the rule second from last, not first.

3. css is the way to go, but if there were any exception it could be for xul width/height, for this specific situation.  ie, you now have to add it to 3 Tb files, and to be polite, you should also add it to suite/ css and get separate review.  but it's totally josiah's call.
Comment on attachment 8444145 [details] [diff] [review]
patch, v2

Review of attachment 8444145 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, just a couple nits (which alta already pointed out)...

::: mail/themes/linux/mail/newsblog/feed-subscriptions.css
@@ +6,5 @@
>  /* ::::: Feed Subscription styling :::::: */
>  
> +#autotagPrefix {
> +  width: 400px;
> +}

Yes, please move this entire rule down quite a ways, and change the value to 300px.

::: mail/themes/osx/mail/newsblog/feed-subscriptions.css
@@ +6,5 @@
>  /* ::::: Feed Subscription styling :::::: */
>  
> +#autotagPrefix {
> +  width: 400px;
> +}

Ditto.

::: mail/themes/windows/mail/newsblog/feed-subscriptions.css
@@ +6,5 @@
>  /* ::::: Feed Subscription styling :::::: */
>  
> +#autotagPrefix {
> +  width: 400px;
> +}

Ditto.
Attachment #8444145 - Flags: review?(josiah) → review+
https://hg.mozilla.org/comm-central/rev/c90b864ef459
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
You need to log in before you can comment on or make changes to this bug.