1013223 - Video playback pause -play is not working for headset events

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Selvaraj]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131115110311

Steps to reproduce:

OS Version: 2.0.0.0-prerelease
Hardware Version: Mako
platform version:31.0a1
Build identifier:20140515174422
Git commit info: 2014-05-05 16:59:23 d33e4f15
1.Insert the headset
2.Play Video/movies on the device
3.Click headset button to pause the video



Actual results:

Video is not paused and the video is keep playing


Expected results:

Video should pause for the headset button press

Comment 1

[Selvaraj]

Attachment: PR

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 8425418 [details] [review]
PR

I'm not the right person to review this patch, sorry.

Comment 3

[Russ Nicoletti [:russn]]

Comment on attachment 8425418 [details] [review]
PR

Hi, your patch looks good for the most part. I added some comments in the PR. I am giving r- for now, although I expect I can approve after your next iteration of the code. Btw, I assume you have tested it (I'm not able to test).

Comment 4

[Bruce Sun [:brsun]]

Comment on attachment 8425418 [details] [review]
PR

Sorry that I am not the right person to review this patch, either.

Comment 5

[Selvaraj]

Attachment: github PR

Incorporated the review comments

Comment 6

[Russ Nicoletti [:russn]]

Comment on attachment 8426107 [details] [review]
github PR

r- for a linter issue that broke the CI build. See my comments in the PR for other "style" issues. Once those are corrected, the patch is good to go.

Comment 7

[Selvaraj]

I have updated the patch ..please review

Comment 8

[BMO Automation]

Firefox OS is not being worked on