1013278 - New Maker Party website isn't localized yet, causing some broken links on webmaker.org

Status: RESOLVED FIXED

(Webmaker Graveyard :: Maker Party, defect)

Description

[Ricardo Panaggio [:panaggio]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 (Beta/Release)
Build ID: 20140516030204

Steps to reproduce:

* Go to https://webmaker.org/pt-BR/about
* Click "Maker Party" link in the bottom


Actual results:

* Opened http://party.webmaker.org/pt-BR
* Got a "Cannot GET /pt-BR"


Expected results:

* Open http://party.webmaker.org/pt-BR properly

Comment 1

[Ricardo Panaggio [:panaggio]]

I gave just one example. That happens in several other places. I could find some greping, but there could be more:

* ./public_angular/js/controllers.js:          target: 'http://party.webmaker.org/' + CONFIG.lang + '/partners'
* ./views/teach.html:    "url": "http://party.webmaker.org/{{localeInfo.lang}}"
* ./views/about.html:    "url": "http://party.webmaker.org/{{localeInfo.lang}}"
* ./views/layout.html:      "url": "http://party.webmaker.org/{{localeInfo.lang}}"
* ./views/privacy-makes.html:    "url": "http://party.webmaker.org/{{localeInfo.lang}}"
* ./views/tools.html:"url": "http://party.webmaker.org/{{localeInfo.lang}}"
* ./locale/en_US/explore.json:    "message": "The Webmaker community gets together at events around the world&mdash;at libraries, community centers, internet cafes, or in your own living room. <a href=\"https://events.webmaker.org/{{ lang }}/\">Find an event near you</a>, learn how to <a href=\"https://events.webmaker.org/{{ lang }}/#!/event-guides\">host your own</a>, or get involved with our global <a href=\"http://party.webmaker.org/{{ lang }}/\">Maker Party</a> (July to Sep 2014).",

Again, this is something I could fix myself, but I don't know if we should redirect to party.webmaker.org, or remove these broken links while party.webmaker.org isn't localized, ... If you want, I can fix, I just need a direction.

Comment 2

[Jon Buckley [:jbuck]]

Confirmed

Comment 3

[Jon Buckley [:jbuck]]

Makerparty is currently hard-coded to support only en-US, so we'll need to patch it to use a preference for supported languages: https://github.com/mozilla/makerparty/blob/master/app.js#L31

panaggio: Do you want to patch makerparty?

Comment 4

[Ricardo Panaggio [:panaggio]]

Working on it. First time I run makerparty locally, could take a while. But I'm on it till I finish it. Hope to have a patch and pull request it soon.

Comment 5

[Ricardo Panaggio [:panaggio]]

Attachment: Pull Request on Github

Comment 6

[Jon Buckley [:jbuck]]

http://party.webmaker.org/pt-BR/ is now golden. Thanks :panaggio and :mavis!